Use same-origin resources for compiler bundles. #1038
Merged
+67
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cometkim is attempting to deploy a commit to the ReScript Association Team on Vercel. A member of the Team first needs to authorize it. |
cometkim
force-pushed
the
playground-bundles
branch
from
8c3553f to
59021cf
Compare
fhammerschmidt
approved these changes
May 18, 2025
|
Once checked in, it cannot be undone. Therefore, to avoid bloating the git repository, we shouldn't check in forever. |
|
This will work on Cloudflare pages anyway after changing the command to |
|
Then we switch to Cloudflare Workers. I'll add GitHub Actions to optimize it and get the versioned snapshot deployments and fork previews we want. |
|
Ok, I'm merging it; this won't break the existing Vercel build with a few tweaks. |
cometkim
force-pushed
the
playground-bundles
branch
from
d3ce49f to
998b798
Compare
|
Whoa, option 2 isn't as bad as I expected. Full sync takes only ~20s in the Cloudflare Pages build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compiler JS bundles are uploaded into a Cloudflare R2 bucket.
rescript-lang/rescript#7472
Serving resources from the same-origin removes CORS preflight when visiting the playground and prevents charges for R2 reads.
I made the
sync-bundlesscript to download all resources from the bucket.And we have two options:
Option 2 is not feasible for Vercel deployments, but for Cloudflare Pages.
Alternatively, we can run a custom deployment with GitHub Actions (When we use Cloudflare Workers instead of Pages). Option 2 +
@actions/cachewould be the best.